Add disabled attribute assertion to BitSelectItemGroup test#80
Merged
albx merged 2 commits intofeature/38-select-componentfrom Feb 9, 2026
Merged
Add disabled attribute assertion to BitSelectItemGroup test#80albx merged 2 commits intofeature/38-select-componentfrom
albx merged 2 commits intofeature/38-select-componentfrom
Conversation
Merged
Co-authored-by: albx <5121303+albx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix first BitSelectItemGroup to be disabled in select component
Add disabled attribute assertion to BitSelectItemGroup test
Feb 9, 2026
albx
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #78 review comment. The test
BitSelectField_Should_Render_Option_Group_Disabled_If_Disabled_Property_Is_Set_To_True()claimed to verify disabled option groups but neither set the property nor asserted the rendered attribute.Changes:
Disabled="true"on firstBitSelectItemGroupin test componentdisabledattribute on corresponding<optgroup>in expected markupExpected markup now correctly validates:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.