Skip to content

Add disabled attribute assertion to BitSelectItemGroup test#80

Merged
albx merged 2 commits intofeature/38-select-componentfrom
copilot/sub-pr-78-again
Feb 9, 2026
Merged

Add disabled attribute assertion to BitSelectItemGroup test#80
albx merged 2 commits intofeature/38-select-componentfrom
copilot/sub-pr-78-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Addresses feedback on PR #78 review comment. The test BitSelectField_Should_Render_Option_Group_Disabled_If_Disabled_Property_Is_Set_To_True() claimed to verify disabled option groups but neither set the property nor asserted the rendered attribute.

Changes:

  • Set Disabled="true" on first BitSelectItemGroup in test component
  • Assert disabled attribute on corresponding <optgroup> in expected markup
<BitSelectItemGroup Label="Group 1" Disabled="true">
    <BitSelectItem TValue="string" Value="@("value 1")">value 1</BitSelectItem>
    <BitSelectItem TValue="string" Value="@("value 2")">value 2</BitSelectItem>
</BitSelectItemGroup>

Expected markup now correctly validates:

<optgroup label="Group 1" disabled>
    <option value="value 1">value 1</option>
    <option value="value 2"> value 2</option>
</optgroup>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: albx <5121303+albx@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix first BitSelectItemGroup to be disabled in select component Add disabled attribute assertion to BitSelectItemGroup test Feb 9, 2026
Copilot AI requested a review from albx February 9, 2026 12:52
@albx albx marked this pull request as ready for review February 9, 2026 15:22
@albx albx merged commit cbf6116 into feature/38-select-component Feb 9, 2026
1 check passed
@albx albx deleted the copilot/sub-pr-78-again branch February 11, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants